| operations |
| comment | | "parent_author":"irelandscape",<br>"parent_permlink":"stemq-beneficiaries-development",<br>"author":"irelandscape",<br>"permlink":"re-irelandscape-stemq-beneficiaries-development-20190131t100806187z",<br>"title":"",<br>"body":"Hi,<br> thanks for your review!\n\nHere are my replies to your comments:\n\n> A few places where you could replace let with const\n\nAgreed.\n\n>You may want to use steem.utils.validateAccountName to validate the user name instead of .acount.length >= 4.\n\nStemQ uses dsteem,<br> not steem-js. StemQ invokes the getAccounts API to check if the username is valid once the number of characters entered reaches 4.\n\n> onOK and mouted are empty,<br> do we really need them?\n\nNo,<br> it probably should be taken out.\n\n> do we really need this.form.beneficiaries = [...this.form.beneficiaries ?\n\nI believe it is required. See the #caveats section on the [Vue list description page (https:\/\/vuejs.org\/v2\/guide\/list.html#Array-Change-Detection)\n\n> is there a chance that max could be negative?\n\nI don't think this is possible since the \"checkWeight\" method ensures that the modified beneficiary doesn't result in a total weight exceeding 100%:\n```javascript\nbeneficiary.weight = Math.min(beneficiary.weight,<br> max)\n```\n\n> a few more comments would be nice\n\nI tend to be parsimonious with comments as it can really make the code less readable.\nI would normally add comments where the code is complex and not self explanatory.\nPlease let me know where clarifications through comments could be added.\n\n> maybe you can refactor and extract the logics to a few functions\/modules so that you can unit test them.\n\nI'm a bit unfamiliar as to unit testing this kind of applications.\nI have a good bit to learn in that area.\n\nThanks again for your review.",<br>"json_metadata":" \"tags\":[\"utopian-io\" ,<br>\"community\":\"steempeak\",<br>\"app\":\"steempeak\/1.7.0\" " |
|